Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process the definition via layout plugin manager, so the new plugin get fully populated. #289

Open
wants to merge 1 commit into
base: 8.x-1.x
Choose a base branch
from
Open

Process the definition via layout plugin manager, so the new plugin get fully populated. #289

wants to merge 1 commit into from

Conversation

dlopez-akalam
Copy link

As long as the plugin manager process the definition individually there would be no performance impact.
Without the patch \Drupal\Core\Layout\LayoutPluginManager::getThemeImplementations() process wrongly the layout patterns

@christianwiedemann
Copy link
Contributor

I applied the patch and my pattern crashes in layout_discovery.module:44. There is no content variable. Did I missed something.

@geek-andi
Copy link

I applied the patch and my pattern crashes in layout_discovery.module:44. There is no content variable. Did I missed something.

The same happens for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants